[Lldb-commits] [PATCH] D47792: Fix up Info.plist when building LLDB.framework with CMake
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 6 11:51:15 PDT 2018
xiaobai added inline comments.
Comment at: source/API/CMakeLists.txt:184
+ set(EXECUTABLE_NAME "LLDB")
+ set(CURRENT_PROJECT_VERSION "360.99.0")
> sas wrote:
> > clayborg wrote:
> > > Currently the apple generic versioning is used and the value for this is grabbed from CURRENT_PROJECT_VERSION in the Xcode project in lldb.xcodeproj/project.pbxproj. We will need to let people know that they will need to update this variable from now on.
> > Hardcoding this here isn't ideal. Where did you get this number from? Is there a way to fetch it from a single location?
> It was hardcoded into the Xcode project before. The numbers would be manually bumped by using "agvtool bump -all". That would update the Xcode project and a few plist files. Feel free to try running that from the root LLDB directory to see all files that get updated, then revert once you see what changed.
In the meantime, is hardcoding this version an acceptable thing to do? Additionally, this value is actually hardcoded in the Info.plist as CFBundleVersion, but filled in with CURRENT_PROJECT_VERSION in CFBundleShortVersionString. That seems kind of clowny.
More information about the lldb-commits