[Lldb-commits] [PATCH] D47801: Make lldb tools dependent on liblldb target when building LLDB.framework with CMake
Alex Langford via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Jun 6 11:33:31 PDT 2018
xiaobai added a comment.
> No existing INCLUDE_IN_FRAMEWORK tool links to liblldb, just it's individual components, which is fine. And this is probably a state that we should maintain for the future.
I think I agree with you here.
> So, how about we do this instead:
> - rename INCLUDE_IN_FRAMEWORK to something more neutral (USED_BY_LIBLLDB or whatever)
> - make the liblldb -> tool dependency not conditioned by LLDB_BUILD_FRAMEWORK
> - remove the lldb->tool dependencies altogether
I think that this a good short-term solution. My concern is your suggestion doesn't reflect the actual dependencies, but conveniently errs on the side of "build it if we think we might need it". I'm not against your suggestion, but I'd like to see if we can come up with something better.
One idea I had was to introduce another target for the framwork itself, e.g. lldbFramework, which gets built if LLDB_BUILD_FRAMEWORK is set. It would depend on liblldb and all the necessary tools, headers, etc, that the framework would need. That way liblldb can depend only on what it needs to build instead of treating it as both the library and the entire framework. How do you feel about this?
More information about the lldb-commits