[Lldb-commits] [PATCH] D47832: DebugNamesDWARFIndex: Add support for partial indexes

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 6 09:57:11 PDT 2018


clayborg accepted this revision.
clayborg added a comment.
This revision is now accepted and ready to land.

Just one nit you can choose to fix or not.



================
Comment at: source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp:39-41
+    if (!unit)
+      continue;
+    if (m_units_to_avoid.find(unit->GetOffset()) != m_units_to_avoid.end())
----------------
Simpler code:
```
if (!unit || m_units_to_avoid.count(unit->GetOffset())
  continue;
```


https://reviews.llvm.org/D47832





More information about the lldb-commits mailing list