[Lldb-commits] [PATCH] D47797: [lldb-mi] Re-implement MI -exec-next command.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Jun 6 00:45:44 PDT 2018

labath added inline comments.

Comment at: tools/lldb-mi/MICmdCmdExec.cpp:384
   if (nThreadId != UINT64_MAX)
-    strCmd += CMIUtilString::Format(" %llu", nThreadId);
-  rDebugger.GetCommandInterpreter().HandleCommand(strCmd.c_str(), m_lldbResult,
-                                                  false);
+    rSessionInfo.GetProcess().GetThreadByID(nThreadId).StepOver();
+  else
It looks like this branch is not covered by the test. Also, do we care about what happens when the client specifies an invalid thread id?
(I'm mainly pointing these out because these seem like they would be hard to test in the current framework, the thread ids being unpredictable and all.)


More information about the lldb-commits mailing list