[Lldb-commits] [PATCH] D47742: Change SWIG output directory when building LLDB.framework with CMake

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon Jun 4 15:40:16 PDT 2018

xiaobai added inline comments.

Comment at: scripts/CMakeLists.txt:38
sas wrote:
> ...and this path were not the same before your change. Was that a bug that you're fixing?
Yes. Those paths were actually the same if you were not building the framework, which is why this bug never surfaced. Specifically, `${CMAKE_CURRENT_BINARY_DIR}` in scripts/CMakeLists.txt resolves to  the same path as `${CMAKE_CURRENT_BINARY_DIR}/scripts` in the top level CMakeLists.txt.

The pitfall is the assumption that this path is always the same as `${LLDB_PYTHON_TARGET_DIR}`, which it is not if you are trying to build the framework.


More information about the lldb-commits mailing list