[Lldb-commits] [PATCH] D47646: [IRMemoryMap] Use labels in the "malloc" and "free" lldb-test commands

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

Looks great, thanks for doing this.

As far as windows goes, I believe that there we simply don't have the memory allocation part implemented, so it's not surprising that these tests fail. It may be possible that the host-only tests would work (if you remove the `CanJIT` check in lldb-test), but I can't say that for sure.



================
Comment at: tools/lldb-test/lldb-test.cpp:606
+  // ::= free <label>
+  if (!Line.startswith("free"))
     return false;
----------------
`s/startswith/consumeFront`. Then, you don't need to do the `.find(' ')` below.


https://reviews.llvm.org/D47646