[Lldb-commits] [PATCH] D47629: [DWARF] Add (empty) DebugNamesDWARFIndex class and a setting to control its use

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Jun 1 06:16:34 PDT 2018


labath created this revision.
labath added reviewers: JDevlieghere, clayborg, jingham.
Herald added subscribers: aprantl, mehdi_amini, mgorny.

This patch is pretty much a big noop. It adds the ability to create a
DebugNamesDWARFIndex class, but the class itself is not implemented in
any useful way. The I am putting it up this way is because of the
setting to control whether it gets used. My idea for it was the
following:

- while the feature is under development (which hopefully won't take much longer), it will default to off. Tests will override it to true.
- once the feature is complete and we are reasonably certain it works, we flip the switch to "on" while keeping the ability to turn it off for troubleshooting purposes.
- after it has been on for a release or two and it hasn't blown up into anyone's face, we remove the setting altogether.


https://reviews.llvm.org/D47629

Files:
  source/Plugins/SymbolFile/DWARF/CMakeLists.txt
  source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.cpp
  source/Plugins/SymbolFile/DWARF/DebugNamesDWARFIndex.h
  source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47629.149443.patch
Type: text/x-patch
Size: 8976 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180601/973c8426/attachment.bin>


More information about the lldb-commits mailing list