[Lldb-commits] [PATCH] D47495: [FileSpec] Re-implmenet removeLastPathComponent

[Pavel Labath via Phabricator via lldb-commits]

labath added inline comments.


================
Comment at: unittests/Utility/FileSpecTest.cpp:342
+  EXPECT_FALSE(fs_posix_relative.RemoveLastPathComponent());
+  EXPECT_STREQ("foo", fs_posix_relative.GetCString());
+
----------------
Is this the behavior you want here? I was thinking we could fold this all the way to "." (arguably "." is a parent of "foo", though I can see how that may be thought to be too magical)


https://reviews.llvm.org/D47495