[Lldb-commits] [PATCH] D47412: Add missing includes to some LLDB headers.

Raphael Isemann via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Sat May 26 08:02:14 PDT 2018


teemperor created this revision.
Herald added a subscriber: ki.stfu.

When compiling with modules, these missing includes cause the build to fail (as the header can't be compiled into a module).


https://reviews.llvm.org/D47412

Files:
  source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.h
  source/Plugins/Process/Utility/InstructionUtils.h
  source/Plugins/Process/Utility/UnwindLLDB.h
  tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.h


Index: tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.h
===================================================================
--- tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.h
+++ tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.h
@@ -14,6 +14,7 @@
 #include "MICmnMIValueList.h"
 #include "MICmnMIValueTuple.h"
 #include "MIUtilSingletonBase.h"
+#include "lldb/API/SBEvent.h"
 
 // Declarations:
 class CMICmnLLDBDebugSessionInfo;
Index: source/Plugins/Process/Utility/UnwindLLDB.h
===================================================================
--- source/Plugins/Process/Utility/UnwindLLDB.h
+++ source/Plugins/Process/Utility/UnwindLLDB.h
@@ -17,6 +17,7 @@
 // Other libraries and framework includes
 // Project includes
 #include "lldb/Symbol/FuncUnwinders.h"
+#include "lldb/Symbol/SymbolContext.h"
 #include "lldb/Symbol/UnwindPlan.h"
 #include "lldb/Target/RegisterContext.h"
 #include "lldb/Target/Unwind.h"
Index: source/Plugins/Process/Utility/InstructionUtils.h
===================================================================
--- source/Plugins/Process/Utility/InstructionUtils.h
+++ source/Plugins/Process/Utility/InstructionUtils.h
@@ -10,6 +10,9 @@
 #ifndef lldb_InstructionUtils_h_
 #define lldb_InstructionUtils_h_
 
+#include <cassert>
+#include <cstdint>
+
 // Common utilities for manipulating instruction bit fields.
 
 namespace lldb_private {
Index: source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.h
===================================================================
--- source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.h
+++ source/Plugins/DynamicLoader/Hexagon-DYLD/HexagonDYLDRendezvous.h
@@ -11,8 +11,10 @@
 #define liblldb_HexagonDYLDRendezvous_H_
 
 // C Includes
+#include <limits.h> // for PATH_MAX
 // C++ Includes
 #include <list>
+#include <map>
 #include <string>
 
 // Other libraries and framework includes


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D47412.148721.patch
Type: text/x-patch
Size: 1874 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180526/bb0fbd4f/attachment.bin>


More information about the lldb-commits mailing list