[Lldb-commits] [PATCH] D46810: 3/3: Fix DWARFUnit::GetUnitDIEPtrOnly stale pointer

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri May 25 01:08:19 PDT 2018

labath added a comment.

+1 for the cleanup. The `m_die_array_size` function is just weird

Comment at: source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:312
 void DWARFUnit::ClearDIEs(bool keep_compile_unit_die) {
+  m_die_array.clear();
You are ignoring the keep_compile_unit_die argument here. Is that intentional? (I would be fine with not being able to clear the unit die, but if we got that way, then we should remove this argument altogether.)


More information about the lldb-commits mailing list