[Lldb-commits] [PATCH] D47278: Remove lldb-private headers when building LLDB.framework with CMake

Alex Langford via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 24 11:56:22 PDT 2018

xiaobai added a comment.

In https://reviews.llvm.org/D47278#1110777, @labath wrote:

> From a layering perspective, it makes sense for SystemInitializerFull to live in the outermost layer, as it's the thing which makes sure liblldb pulls in all required components. Since it is only included from files in `source/API` (which is as it should be), maybe we could just make it a private header and move the file to `source/API/SystemInitializerFull.h`?

This makes the most sense to me. I've uploaded https://reviews.llvm.org/D47342 which I believe does what you've suggested.

In https://reviews.llvm.org/D47278#1110333, @clayborg wrote:

> The issue is actually that SystemInitializerFull.h and SystemInitializerFull.cpp are in the wrong directories. They belong in the "lldb/Initialization" and "Source//Initialization". We should fix this and then some/all of your changes won't be needed?

Some of them for sure. It's a mistake to add `${LLDB_SOURCE_DIR}/include/lldb/lldb-*.h` to `public_headers`, so that should still be changed.


More information about the lldb-commits mailing list