[Lldb-commits] [PATCH] D47232: Break dependency from Expression -> Commands
Zachary Turner via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed May 23 17:10:12 PDT 2018
zturner added a comment.
In https://reviews.llvm.org/D47232#1108865, @jingham wrote:
> Perhaps a better way to handle this is to think of REPL.cpp/h as adjuncts of CommandObjectExpression.cpp/h - they mostly define the fancy IOHandler that gets pushed when you run the command in this mode. I think it would be fine to move them to Command, at which point using all the OptionGroups would be expected.
`Core` doesn't currently have a dependency on `Commands` (few things do actually), and I would prefer not to add one. But several things include `REPL.h` (notably `Debugger.cpp` and `Target.cpp`. So if I move this file to `Commands` it would introduce 2 extra edges in the dependency graph both of which would introduce a new layering violation.
More information about the lldb-commits