[Lldb-commits] [PATCH] D47302: [lldb, lldb-mi] Add method AddCurrentTargetSharedObjectPath to the SBDebugger.

Alexander Polyakov via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 23 17:03:41 PDT 2018

polyakov.alex added a comment.

In https://reviews.llvm.org/D47302#1110441, @aprantl wrote:

> The missing context here is that the lldb-mi -target-select command currently calls `HandleCommand("target modules search-paths add", ...)`.
>  Is adding a new SBAPI the right approach to implementing this functionality without going through HandleCommand? Or is HandleCommand appropriate in this case?

This approach is not mandatory, we could do almost the same(except errors processing) right in TargetSelect::Execute method. As you can see, the main thing here is:

            ConstString(from), ConstString(to), true);



More information about the lldb-commits mailing list