[Lldb-commits] [PATCH] D47235: Move ModuleList's dependency on clangDriver into Host

Zachary Turner via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 23 11:07:33 PDT 2018

zturner added a comment.

Can you revert the changes to `HostInfoBase.h`?  It looks like now it's only whitespace changes.

Comment at: source/Core/ModuleList.cpp:16
 #include "lldb/Host/Symbols.h"
+#include "lldb/Host/HostInfoBase.h"
 #include "lldb/Interpreter/OptionValueProperties.h"
I think we don't need this include anymore.

Comment at: source/Core/ModuleList.cpp:94
-  llvm::SmallString<128> path;
-  clang::driver::Driver::getDefaultModuleCachePath(path);
-  SetClangModulesCachePath(path);
+  assert(!g_default_clang_modules_cache_path.empty());
+  SetClangModulesCachePath(g_default_clang_modules_cache_path);
I don't think this should be an assert.  After all, if the whole point is to make LLDB usable in situations where clang is not present, then someone using it in such an environment would probably never call the static function to begin with.  So I think we should just remove the assert and set it to whatever the value happens to be (including empty)


More information about the lldb-commits mailing list