[Lldb-commits] [PATCH] D47228: Break dependency from Core to ObjectFileJIT

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed May 23 01:34:35 PDT 2018

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

The change sounds reasonable to me. I should just point out that this is the Core <-> ObjectFile**JIT** cycle you are breaking.

Comment at: lldb/include/lldb/Core/Module.h:165
+    module_sp->m_objfile_sp =
+        std::make_shared<ObjFilePlugin>(module_sp, args...);

Comment at: lldb/source/Expression/IRExecutionUnit.cpp:35-36
 #include "lldb/../../source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.h"
+#include "lldb/../../source/Plugins/ObjectFile/JIT/ObjectFileJIT.h"
`#include "Plugins/Language/CPlusPlus/CPlusPlusLanguage.h"` should work here


More information about the lldb-commits mailing list