[Lldb-commits] [PATCH] D47021: Fix PathMappingList for relative and empty paths after recent FileSpec normalization changes

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Mon May 21 01:57:31 PDT 2018

labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.

looks good. I don't know if anyone else has an opinion on how should we treat "" for mapping purposes, but treating it as "." seems fine to me.

Comment at: unittests/Utility/FileSpecTest.cpp:300
+  for (const auto &path: not_relative) {
+    FileSpec spec(path, false, FileSpec::Style::posix);
+    EXPECT_FALSE(spec.IsRelative());
In tests like these, it's good to add something like `SCOPED_TRACE(path)` or similar. That way, when a test fails you will see which path caused the failure instead of just a generic "spec.IsRelative() is true" message.


More information about the lldb-commits mailing list