[Lldb-commits] [PATCH] D46889: [DWARF] Extract indexing code into a separate class hierarchy

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu May 17 07:16:36 PDT 2018

clayborg added inline comments.

Comment at: source/Plugins/SymbolFile/DWARF/DWARFIndex.cpp:40
+std::unique_ptr<AppleIndex> AppleIndex::Create(
+    Module &module, DWARFDataExtractor apple_names,
clayborg wrote:
> Move all AppleIndex stuff to a dedicated .cpp file?
Do we want all DWARFIndex::Create(...) signatures to take a SymbolFileDWARF only? Then module can be extracted from that and all sections can be fetched as well?


More information about the lldb-commits mailing list