[Lldb-commits] [lldb] r332596 - [DWARF] Have HashedNameToDIE store a DataExtractor by value

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Thu May 17 04:36:08 PDT 2018

Author: labath
Date: Thu May 17 04:36:08 2018
New Revision: 332596

URL: http://llvm.org/viewvc/llvm-project?rev=332596&view=rev
[DWARF] Have HashedNameToDIE store a DataExtractor by value

The DataExtractors are cheap to copy so there is no reason to store them
by reference. Also, in my upcoming indexing refactor I am planning to
remove the apple tables data extractor members from the SymbolFileDWARF
class, so there will not be a DataExtractor with a suitable lifetime to
refer to.

Reviewers: clayborg, JDevlieghere

Subscribers: aprantl, lldb-commits

Differential Revision: https://reviews.llvm.org/D46888


Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.h?rev=332596&r1=332595&r2=332596&view=diff
--- lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.h (original)
+++ lldb/trunk/source/Plugins/SymbolFile/DWARF/HashedNameToDIE.h Thu May 17 04:36:08 2018
@@ -156,8 +156,8 @@ public:
                               lldb::offset_t *hash_data_offset_ptr,
                               Pair &pair) const override;
-    const lldb_private::DWARFDataExtractor &m_data;
-    const lldb_private::DWARFDataExtractor &m_string_table;
+    lldb_private::DWARFDataExtractor m_data;
+    lldb_private::DWARFDataExtractor m_string_table;
     std::string m_name;

More information about the lldb-commits mailing list