[Lldb-commits] [PATCH] D46783: FileSpec objects that resolve to "." should have "." in m_filename and m_directory empty.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue May 15 08:13:30 PDT 2018

clayborg added a comment.

In https://reviews.llvm.org/D46783#1097549, @labath wrote:

> Preserving the dot if it is the only path component is perfectly reasonable -- "" is not a valid path and we shouldn't convert a valid path into an invalid one. However, I think this should be done on the llvm side, in the `remote_dots` function and not as a workaround on top of it.

so the issue isn't just keeping a single ".", but "./" and "foo/.." and many others that result in the "." as being the result. And I don't think changing a function that is supposed to remove dots to not actually remove them is a good idea.


More information about the lldb-commits mailing list