[Lldb-commits] [PATCH] D46292: Use the UUID from the minidump's CodeView Record for placeholder modules

[Pavel Labath via Phabricator via lldb-commits]

labath accepted this revision.
labath added a comment.

I think this is fine. I would have preferred a constructor solution, but the situation there does appear to be a bit messy. I like how you were able to place the SetUUID method next to SetArchitecture. Thanks for your patience.



================
Comment at: source/Commands/CommandObjectTarget.cpp:1390
+        else {
+          strm.Printf("No object file for module: %s\n",
+                      module->GetFileSpec().GetFilename().GetCString());
----------------
`strm.Format("No object file for module: {0:F}\n", module->GetFileSpec())` should hopefully fit on a single line


https://reviews.llvm.org/D46292