[Lldb-commits] [PATCH] D45977: Always normalize FileSpec paths.
Greg Clayton via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Apr 25 11:57:30 PDT 2018
clayborg added a comment.
In https://reviews.llvm.org/D45977#1077719, @labath wrote:
> This code itself looks fine, I have just two minor comments.
> However, I do have a question about performance. I remember us being very worried about performance in the past, so we ended up putting in this like r298876. This removes the normalization step during FileSpec comparison, but it introduces mandatory normalization upon every FileSpec creation, so it's not obvious to me what will this do to performance. Should we try to benchmark this somehow?
Ok, so I ran a benchmark and we are about 7% slower on a completely cold file cache, and 9% slower on a warm file cache. If I add the needsNormalization() function back in, we are 7% faster for cold, and 10% faster for warm. So I will add the needsNormalization() back in.
More information about the lldb-commits