[Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Apr 24 09:42:09 PDT 2018

labath added a comment.

In https://reviews.llvm.org/D46005#1076978, @zturner wrote:

> Does it print just the names of the .py files, or does it print the actual test classes and methods in the Class.TestName format, evaluate XFAIL and SKIPs, etc?

It prints everything: test file (including the relative path in the test suite), test class name and test method name.

It does not try to evaluate skips or xfails, but that was never the intention. The idea is to feed this information to lit (as it needs to know about the set of all tests), which can then run them with a bigger (smaller?) granularity. The interpretation of the test results (skip,fail, ...) will still be done by the lit test format, only now it could do it at a test-method level instead of file-level.

> I'm also not entirely clear why `set_up_environment` is even necessary.  Nothing below the call to `set_up_environment` even seems to depend on the environment being set up.

In the main function I call `unittest2.defaultTestLoader.loadTestsFromName(base)`, which deep down does an `__import__(base)`. We need the environment of the import statement to be reasonably close to the the environment that `dotest` provides so that the import will succeed.


More information about the lldb-commits mailing list