[Lldb-commits] [PATCH] D46005: [test] Add a utility for dumping all tests in the dotest suite

[Jonas Devlieghere via Phabricator via lldb-commits]

JDevlieghere added inline comments.


================
Comment at: lit/Suite/lldbtestdumper.py:27
+
+def set_up_environment():
+    global lldb_test_root
----------------
A comment describing what and why this is necessary might be nice. 


================
Comment at: lit/Suite/lldbtestdumper.py:40
+
+    lldb_executable = os.path.abspath(sys.argv[1])
+    site_packages = subprocess.check_output([lldb_executable, '-P']).strip()
----------------
Any objection to parsing the arg in main and passing it as an argument?


https://reviews.llvm.org/D46005