[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

[Jim Ingham via lldb-commits]

> On Mar 20, 2018, at 4:55 AM, Pavel Labath via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> Deleting the test build dir is fairly easy. I can whip up a patch for that, but I'm not sure if that's the part that is bothering you the most here. Dealing with the log files is a bot more complicated and there doesn't seem to be a clear consensus on what to do with them.  The last discussion about the (Jan 17: Questions about the LLDB testsuite and improving its reliability) ended without a clear conclusion. I personally, think it would be nice to put the log files into the build dir, but I don't feel strongly enough about it to go around and try to get people to change their habits.
> 
> 

I like that if I do a bunch of test runs, I can go back and get an earlier failing log to see why some change I made didn't do what I expected.  So I like the date-stamped log directories, though I may be in the minority here.  But that aim could be solved equally well by putting the numbered directories in the build tree as in the source tree (just emit the full path at the end of the run and you just have to cut & paste a little more to go to the log directories.   You'd have to avoid deleting them when you clean the build, but that shouldn't be too hard.  And not littering the source tree is a worthy goal.

My .02.

Jim

> On Mon, 19 Mar 2018 at 17:17, Greg Clayton via Phabricator via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> clayborg added subscribers: labath, clayborg.
> clayborg added a comment.
> 
> I would be nice to have the option to nuke each test build directory if the test passed. Can be an option that we specify. That way, the only folders left over could be the tests that are failing. The options doesn't need to default to true, but if anyone is in that code and would know how to do that, that would be a great option to have. This option could also clean up the log directory and remove any logs for tests that succeeded or were skipped. I alway have to go and nuke these files manually.
> 
> Greg
> 
> 
> Repository:
>   rL LLVM
> 
> https://reviews.llvm.org/D44526
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits