[Lldb-commits] [lldb] r327996 - Move StringExtractorGDBRemote.h to the include folder

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Tue Mar 20 09:14:00 PDT 2018


Author: labath
Date: Tue Mar 20 09:14:00 2018
New Revision: 327996

URL: http://llvm.org/viewvc/llvm-project?rev=327996&view=rev
Log:
Move StringExtractorGDBRemote.h to the include folder

While trying to use this header I noticed that it is not in the include
folder. Move it to there and update all #includes to reference that file
correctly.

Added:
    lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h
      - copied, changed from r327981, lldb/trunk/source/Utility/StringExtractorGDBRemote.h
Removed:
    lldb/trunk/source/Utility/StringExtractorGDBRemote.h
Modified:
    lldb/trunk/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
    lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp
    lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp

Copied: lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h (from r327981, lldb/trunk/source/Utility/StringExtractorGDBRemote.h)
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h?p2=lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h&p1=lldb/trunk/source/Utility/StringExtractorGDBRemote.h&r1=327981&r2=327996&rev=327996&view=diff
==============================================================================
--- lldb/trunk/source/Utility/StringExtractorGDBRemote.h (original)
+++ lldb/trunk/include/lldb/Utility/StringExtractorGDBRemote.h Tue Mar 20 09:14:00 2018
@@ -7,8 +7,8 @@
 //
 //===----------------------------------------------------------------------===//
 
-#ifndef utility_StringExtractorGDBRemote_h_
-#define utility_StringExtractorGDBRemote_h_
+#ifndef LLDB_UTILITY_STRINGEXTRACTORGDBREMOTE_H
+#define LLDB_UTILITY_STRINGEXTRACTORGDBREMOTE_H
 
 #include "lldb/Utility/Status.h"
 #include "lldb/Utility/StringExtractor.h"
@@ -201,4 +201,4 @@ protected:
   void *m_validator_baton;
 };
 
-#endif // utility_StringExtractorGDBRemote_h_
+#endif // LLDB_UTILITY_STRINGEXTRACTORGDBREMOTE_H

Modified: lldb/trunk/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Utility/RegisterContextMacOSXFrameBackchain.cpp Tue Mar 20 09:14:00 2018
@@ -19,7 +19,7 @@
 #include "lldb/Utility/DataExtractor.h"
 #include "lldb/Utility/StreamString.h"
 // Project includes
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 using namespace lldb;
 using namespace lldb_private;

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.h Tue Mar 20 09:14:00 2018
@@ -27,7 +27,7 @@
 #include "lldb/Interpreter/Args.h"
 #include "lldb/lldb-public.h"
 
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 namespace lldb_private {
 namespace process_gdb_remote {

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp Tue Mar 20 09:14:00 2018
@@ -36,8 +36,8 @@
 // Project includes
 #include "ProcessGDBRemote.h"
 #include "ProcessGDBRemoteLog.h"
-#include "Utility/StringExtractorGDBRemote.h"
 #include "lldb/Host/Config.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 #include "llvm/ADT/StringSwitch.h"
 

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp Tue Mar 20 09:14:00 2018
@@ -19,8 +19,8 @@
 
 // Project includes
 #include "ProcessGDBRemoteLog.h"
-#include "Utility/StringExtractorGDBRemote.h"
 #include "lldb/Utility/StreamString.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 using namespace lldb;
 using namespace lldb_private;

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerCommon.cpp Tue Mar 20 09:14:00 2018
@@ -43,7 +43,7 @@
 
 // Project includes
 #include "ProcessGDBRemoteLog.h"
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 #ifdef __ANDROID__
 #include "lldb/Host/android/HostInfoAndroid.h"

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp Tue Mar 20 09:14:00 2018
@@ -49,7 +49,7 @@
 // Project includes
 #include "ProcessGDBRemote.h"
 #include "ProcessGDBRemoteLog.h"
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 using namespace lldb;
 using namespace lldb_private;

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerPlatform.cpp Tue Mar 20 09:14:00 2018
@@ -38,7 +38,7 @@
 #include "lldb/Utility/UriParser.h"
 
 // Project includes
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 using namespace lldb;
 using namespace lldb_private;

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp Tue Mar 20 09:14:00 2018
@@ -25,7 +25,7 @@
 #include "ThreadGDBRemote.h"
 #include "Utility/ARM_DWARF_Registers.h"
 #include "Utility/ARM_ehframe_Registers.h"
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 using namespace lldb;
 using namespace lldb_private;

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp Tue Mar 20 09:14:00 2018
@@ -78,8 +78,8 @@
 #include "ProcessGDBRemote.h"
 #include "ProcessGDBRemoteLog.h"
 #include "ThreadGDBRemote.h"
-#include "Utility/StringExtractorGDBRemote.h"
 #include "lldb/Host/Host.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 #include "llvm/ADT/StringSwitch.h"
 #include "llvm/Support/Threading.h"

Modified: lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp (original)
+++ lldb/trunk/source/Plugins/Process/gdb-remote/ThreadGDBRemote.cpp Tue Mar 20 09:14:00 2018
@@ -24,7 +24,7 @@
 
 #include "ProcessGDBRemote.h"
 #include "ProcessGDBRemoteLog.h"
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 using namespace lldb;
 using namespace lldb_private;

Modified: lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp?rev=327996&r1=327995&r2=327996&view=diff
==============================================================================
--- lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp (original)
+++ lldb/trunk/source/Utility/StringExtractorGDBRemote.cpp Tue Mar 20 09:14:00 2018
@@ -7,7 +7,7 @@
 //
 //===----------------------------------------------------------------------===//
 
-#include "Utility/StringExtractorGDBRemote.h"
+#include "lldb/Utility/StringExtractorGDBRemote.h"
 
 #include <ctype.h> // for isxdigit
 #include <string.h>

Removed: lldb/trunk/source/Utility/StringExtractorGDBRemote.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Utility/StringExtractorGDBRemote.h?rev=327995&view=auto
==============================================================================
--- lldb/trunk/source/Utility/StringExtractorGDBRemote.h (original)
+++ lldb/trunk/source/Utility/StringExtractorGDBRemote.h (removed)
@@ -1,204 +0,0 @@
-//===-- StringExtractorGDBRemote.h ------------------------------*- C++ -*-===//
-//
-//                     The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#ifndef utility_StringExtractorGDBRemote_h_
-#define utility_StringExtractorGDBRemote_h_
-
-#include "lldb/Utility/Status.h"
-#include "lldb/Utility/StringExtractor.h"
-#include "llvm/ADT/StringRef.h" // for StringRef
-
-#include <string>
-
-#include <stddef.h> // for size_t
-#include <stdint.h> // for uint8_t
-
-class StringExtractorGDBRemote : public StringExtractor {
-public:
-  typedef bool (*ResponseValidatorCallback)(
-      void *baton, const StringExtractorGDBRemote &response);
-
-  StringExtractorGDBRemote() : StringExtractor(), m_validator(nullptr) {}
-
-  StringExtractorGDBRemote(llvm::StringRef str)
-      : StringExtractor(str), m_validator(nullptr) {}
-
-  StringExtractorGDBRemote(const char *cstr)
-      : StringExtractor(cstr), m_validator(nullptr) {}
-
-  StringExtractorGDBRemote(const StringExtractorGDBRemote &rhs)
-      : StringExtractor(rhs), m_validator(rhs.m_validator) {}
-
-  virtual ~StringExtractorGDBRemote() {}
-
-  bool ValidateResponse() const;
-
-  void CopyResponseValidator(const StringExtractorGDBRemote &rhs);
-
-  void SetResponseValidator(ResponseValidatorCallback callback, void *baton);
-
-  void SetResponseValidatorToOKErrorNotSupported();
-
-  void SetResponseValidatorToASCIIHexBytes();
-
-  void SetResponseValidatorToJSON();
-
-  enum ServerPacketType {
-    eServerPacketType_nack = 0,
-    eServerPacketType_ack,
-    eServerPacketType_invalid,
-    eServerPacketType_unimplemented,
-    eServerPacketType_interrupt, // CTRL+c packet or "\x03"
-    eServerPacketType_A,         // Program arguments packet
-    eServerPacketType_qfProcessInfo,
-    eServerPacketType_qsProcessInfo,
-    eServerPacketType_qC,
-    eServerPacketType_qEcho,
-    eServerPacketType_qGroupName,
-    eServerPacketType_qHostInfo,
-    eServerPacketType_qLaunchGDBServer,
-    eServerPacketType_qQueryGDBServer,
-    eServerPacketType_qKillSpawnedProcess,
-    eServerPacketType_qLaunchSuccess,
-    eServerPacketType_qModuleInfo,
-    eServerPacketType_qProcessInfoPID,
-    eServerPacketType_qSpeedTest,
-    eServerPacketType_qUserName,
-    eServerPacketType_qGetWorkingDir,
-    eServerPacketType_qFileLoadAddress,
-    eServerPacketType_QEnvironment,
-    eServerPacketType_QEnableErrorStrings,
-    eServerPacketType_QLaunchArch,
-    eServerPacketType_QSetDisableASLR,
-    eServerPacketType_QSetDetachOnError,
-    eServerPacketType_QSetSTDIN,
-    eServerPacketType_QSetSTDOUT,
-    eServerPacketType_QSetSTDERR,
-    eServerPacketType_QSetWorkingDir,
-    eServerPacketType_QStartNoAckMode,
-    eServerPacketType_qPlatform_shell,
-    eServerPacketType_qPlatform_mkdir,
-    eServerPacketType_qPlatform_chmod,
-    eServerPacketType_vFile_open,
-    eServerPacketType_vFile_close,
-    eServerPacketType_vFile_pread,
-    eServerPacketType_vFile_pwrite,
-    eServerPacketType_vFile_size,
-    eServerPacketType_vFile_mode,
-    eServerPacketType_vFile_exists,
-    eServerPacketType_vFile_md5,
-    eServerPacketType_vFile_stat,
-    eServerPacketType_vFile_symlink,
-    eServerPacketType_vFile_unlink,
-    // debug server packages
-    eServerPacketType_QEnvironmentHexEncoded,
-    eServerPacketType_QListThreadsInStopReply,
-    eServerPacketType_QPassSignals,
-    eServerPacketType_QRestoreRegisterState,
-    eServerPacketType_QSaveRegisterState,
-    eServerPacketType_QSetLogging,
-    eServerPacketType_QSetMaxPacketSize,
-    eServerPacketType_QSetMaxPayloadSize,
-    eServerPacketType_QSetEnableAsyncProfiling,
-    eServerPacketType_QSyncThreadState,
-    eServerPacketType_QThreadSuffixSupported,
-
-    eServerPacketType_jThreadsInfo,
-    eServerPacketType_qsThreadInfo,
-    eServerPacketType_qfThreadInfo,
-    eServerPacketType_qGetPid,
-    eServerPacketType_qGetProfileData,
-    eServerPacketType_qGDBServerVersion,
-    eServerPacketType_qMemoryRegionInfo,
-    eServerPacketType_qMemoryRegionInfoSupported,
-    eServerPacketType_qProcessInfo,
-    eServerPacketType_qRcmd,
-    eServerPacketType_qRegisterInfo,
-    eServerPacketType_qShlibInfoAddr,
-    eServerPacketType_qStepPacketSupported,
-    eServerPacketType_qSupported,
-    eServerPacketType_qSyncThreadStateSupported,
-    eServerPacketType_qThreadExtraInfo,
-    eServerPacketType_qThreadStopInfo,
-    eServerPacketType_qVAttachOrWaitSupported,
-    eServerPacketType_qWatchpointSupportInfo,
-    eServerPacketType_qWatchpointSupportInfoSupported,
-    eServerPacketType_qXfer_auxv_read,
-
-    eServerPacketType_jSignalsInfo,
-    eServerPacketType_jModulesInfo,
-
-    eServerPacketType_vAttach,
-    eServerPacketType_vAttachWait,
-    eServerPacketType_vAttachOrWait,
-    eServerPacketType_vAttachName,
-    eServerPacketType_vCont,
-    eServerPacketType_vCont_actions, // vCont?
-
-    eServerPacketType_stop_reason, // '?'
-
-    eServerPacketType_c,
-    eServerPacketType_C,
-    eServerPacketType_D,
-    eServerPacketType_g,
-    eServerPacketType_G,
-    eServerPacketType_H,
-    eServerPacketType_I, // stdin notification
-    eServerPacketType_k,
-    eServerPacketType_m,
-    eServerPacketType_M,
-    eServerPacketType_p,
-    eServerPacketType_P,
-    eServerPacketType_s,
-    eServerPacketType_S,
-    eServerPacketType_T,
-    eServerPacketType_x,
-    eServerPacketType_X,
-    eServerPacketType_Z,
-    eServerPacketType_z,
-
-    eServerPacketType__M,
-    eServerPacketType__m,
-    eServerPacketType_notify, // '%' notification
-
-    eServerPacketType_jTraceStart,
-    eServerPacketType_jTraceBufferRead,
-    eServerPacketType_jTraceMetaRead,
-    eServerPacketType_jTraceStop,
-    eServerPacketType_jTraceConfigRead,
-  };
-
-  ServerPacketType GetServerPacketType() const;
-
-  enum ResponseType { eUnsupported = 0, eAck, eNack, eError, eOK, eResponse };
-
-  ResponseType GetResponseType() const;
-
-  bool IsOKResponse() const;
-
-  bool IsUnsupportedResponse() const;
-
-  bool IsNormalResponse() const;
-
-  bool IsErrorResponse() const;
-
-  // Returns zero if the packet isn't a EXX packet where XX are two hex
-  // digits. Otherwise the error encoded in XX is returned.
-  uint8_t GetError();
-
-  lldb_private::Status GetStatus();
-
-  size_t GetEscapedBinaryData(std::string &str);
-
-protected:
-  ResponseValidatorCallback m_validator;
-  void *m_validator_baton;
-};
-
-#endif // utility_StringExtractorGDBRemote_h_




More information about the lldb-commits mailing list