[Lldb-commits] [PATCH] D44526: [dotest] Clean up test folder clean-up

Greg Clayton via lldb-commits lldb-commits at lists.llvm.org
Mon Mar 19 10:14:11 PDT 2018


I would be nice to have the option to nuke each test build directory if the test passed. Can be an option that we specify. That way, the only folders left over could be the tests that are failing. The options doesn't need to default to true, but if anyone is in that code and would know how to do that, that would be a great option to have. This option could also clean up the log directory and remove any logs for tests that succeeded or were skipped. I alway have to go and nuke these files manually.


Greg

> On Mar 15, 2018, at 10:38 AM, Adrian Prantl via Phabricator via lldb-commits <lldb-commits at lists.llvm.org> wrote:
> 
> aprantl accepted this revision.
> aprantl added a comment.
> This revision is now accepted and ready to land.
> 
> Thanks! I think this makes sense.
> 
> 
> 
> ================
> Comment at: packages/Python/lldbsuite/test/lldbtest.py:707
> +        """Create the test-specific working directory, deleting any previous
> +        contents."""
>         # See also dotest.py which sets up ${LLDB_BUILD}.
> ----------------
> I was thinking whether this was necessary, since we could just `rm -rf` the entire --build-dir, but for running individual tests, doing it this way makes it easier.
> 
> 
> ================
> Comment at: test/CMakeLists.txt:9
>   add_custom_target(${name}
>     # Clear the test directory first.
>     COMMAND ${PYTHON_TEST_COMMAND} ${ARG_DEFAULT_ARGS}
> ----------------
> That comment is obsolete now?
> 
> 
> https://reviews.llvm.org/D44526
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits



More information about the lldb-commits mailing list