[Lldb-commits] [PATCH] D44472: Add and fix some tests for PPC64
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Fri Mar 16 02:25:37 PDT 2018
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
I like what you did with the test. Originally, I wanted to just compare the raw memory contents, but this keeps it more inline with the spirit of the original test. I have just one question about the list zipping, but otherwise lgtm.
Comment at: packages/Python/lldbsuite/test/functionalities/disassembly/TestDisassembleBreakpoint.py:48-49
+ # instructions before inserting breakpoints.
+ for dis_inst_before, dis_inst_after in \
+ zip(disassembly_before_break, disassembly_after_break):
+ inst_before = dis_inst_before.split(':')[-1]
what will this do if the lists are of different length? Should you assert that the length matches as well?
More information about the lldb-commits