[Lldb-commits] [PATCH] D44306: Move Args::StringToAddress to Target::EvaluateAddressExpression

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Wed Mar 14 12:40:31 PDT 2018


jingham added a comment.

As long as these functions are used for parsing options args in individual CommandObject implementations, and don't get dragged lower in the stack, I don't think that's a problem.  By the time you're getting to individual commands you are on top of pretty much everything else in lldb, and can expect to rely on whatever.  And the value of having all the converters gathered in one place so people writing new commands can easily do the right thing when ingesting arguments more than justifies this gathering of disparate elements IMO.


https://reviews.llvm.org/D44306





More information about the lldb-commits mailing list