[Lldb-commits] [PATCH] D44342: Introduce a setting to disable Spotlight while running the test suite

[Greg Clayton via Phabricator via lldb-commits]

clayborg added inline comments.


================
Comment at: source/Core/ModuleList.cpp:70
 PropertyDefinition g_properties[] = {
+    // This option only makes sense when the host is macOS.
+    {"enable-external-lookup", OptionValue::eTypeBoolean, true, true, nullptr,
----------------
Remove this comment? I can apply to any platform in the future that implements symbol lookups right?


================
Comment at: source/Core/ModuleList.cpp:73-74
+     nullptr,
+     "On macOS, use Spotlight to locate a matching .dSYM bundle based on the "
+     "UUID of the executable."},
     {"clang-modules-cache-path", OptionValue::eTypeFileSpec, true, 0, nullptr,
----------------
Maybe restate this a bit? Maybe something like:

```
"Disable using external tools or linked libraries to locate symbol files."
```


https://reviews.llvm.org/D44342