[Lldb-commits] [PATCH] D40474: DWZ 09/11: Main functionality
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Mon Mar 12 09:36:42 PDT 2018
labath added a reviewer: davide.
labath added a comment.
I think the most controversial issue here is the testing... davide may have some thoughts on that.
Comment at: source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:4529
+ std::unique_ptr<SymbolFileDWARF> &&symbol_file,
+ lldb::ObjectFileSP &&obj_file, lldb::ModuleSP &&module)
the references are superfluous here (this just caught my eye because it's at the bottom of the patch).
More information about the lldb-commits