[Lldb-commits] [lldb] r327193 - Rename clang.modules-cache-path to symbols.clang-modules-cache-path

[Adrian Prantl via lldb-commits]

Author: adrian
Date: Fri Mar  9 17:11:25 2018
New Revision: 327193

URL: http://llvm.org/viewvc/llvm-project?rev=327193&view=rev
Log:
Rename clang.modules-cache-path to symbols.clang-modules-cache-path

I want to extend the properties on ModuleList to also contain other
more general settings and renaming the settings category to symbols
seems to be the least bad of choices.

Modified:
    lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py
    lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
    lldb/trunk/source/Core/Debugger.cpp
    lldb/trunk/source/Core/ModuleList.cpp

Modified: lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py?rev=327193&r1=327192&r2=327193&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lang/objc/modules-cache/TestClangModulesCache.py Fri Mar  9 17:11:25 2018
@@ -32,7 +32,7 @@ class ObjCModulesTestCase(TestBase):
           shutil.rmtree(mod_cache)
         self.assertFalse(os.path.isdir(mod_cache),
                          "module cache should not exist")
-        self.runCmd('settings set clang.modules-cache-path "%s"' % mod_cache)
+        self.runCmd('settings set symbols.clang-modules-cache-path "%s"' % mod_cache)
         self.runCmd('settings set target.clang-module-search-paths "%s"'
                     % self.getSourceDir())
         (target, process, thread, bkpt) = lldbutil.run_to_source_breakpoint(

Modified: lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py?rev=327193&r1=327192&r2=327193&view=diff
==============================================================================
--- lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/lldbtest.py Fri Mar  9 17:11:25 2018
@@ -1921,7 +1921,7 @@ class TestBase(Base):
         if self.child:
             assert(self.getDebugInfo() == 'default')
             mod_cache = os.path.join(self.getBuildDir(), "module-cache")
-            self.runCmd('settings set clang.modules-cache-path "%s"'
+            self.runCmd('settings set symbols.clang-modules-cache-path "%s"'
                         % mod_cache)
 
 

Modified: lldb/trunk/source/Core/Debugger.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/Debugger.cpp?rev=327193&r1=327192&r2=327193&view=diff
==============================================================================
--- lldb/trunk/source/Core/Debugger.cpp (original)
+++ lldb/trunk/source/Core/Debugger.cpp Fri Mar  9 17:11:25 2018
@@ -776,8 +776,8 @@ Debugger::Debugger(lldb::LogOutputCallba
       ConstString("platform"), ConstString("Platform settings."), true,
       Platform::GetGlobalPlatformProperties()->GetValueProperties());
   m_collection_sp->AppendProperty(
-      ConstString("clang"), ConstString("Settings specific to Clang."), true,
-      ModuleList::GetGlobalModuleListProperties().GetValueProperties());
+      ConstString("symbols"), ConstString("Symbol lookup and cache settings."),
+      true, ModuleList::GetGlobalModuleListProperties().GetValueProperties());
   if (m_command_interpreter_ap) {
     m_collection_sp->AppendProperty(
         ConstString("interpreter"),

Modified: lldb/trunk/source/Core/ModuleList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ModuleList.cpp?rev=327193&r1=327192&r2=327193&view=diff
==============================================================================
--- lldb/trunk/source/Core/ModuleList.cpp (original)
+++ lldb/trunk/source/Core/ModuleList.cpp Fri Mar  9 17:11:25 2018
@@ -67,7 +67,7 @@ using namespace lldb_private;
 namespace {
 
 PropertyDefinition g_properties[] = {
-    {"modules-cache-path", OptionValue::eTypeFileSpec, true, 0, nullptr,
+    {"clang-modules-cache-path", OptionValue::eTypeFileSpec, true, 0, nullptr,
      nullptr,
      "The path to the clang modules cache directory (-fmodules-cache-path)."},
     {nullptr, OptionValue::eTypeInvalid, false, 0, nullptr, nullptr, nullptr}};
@@ -77,7 +77,7 @@ enum { ePropertyClangModulesCachePath };
 } // namespace
 
 ModuleListProperties::ModuleListProperties() {
-  m_collection_sp.reset(new OptionValueProperties(ConstString("clang")));
+  m_collection_sp.reset(new OptionValueProperties(ConstString("symbols")));
   m_collection_sp->Initialize(g_properties);
 
   llvm::SmallString<128> path;