[Lldb-commits] [PATCH] D44139: WIP: Update selected thread after loading mach core

[Pavel Labath via Phabricator via lldb-commits]

labath added a comment.

I don't know much about OS plugins, but I don't see a reason why this would be mach-specific (so yes, it should probably be done for elf cores as well). Oh, and we also have windows minidumps, but I'm not sure if it should be up to you to update all of these (I'm saying not sure, because the fact that each format needs to be updated specifically may mean that this should be actually done at a different level, but I have no idea if that's possible).

As for testing, the only approach I can think of is a combination of a checked-in core file + a fake os plugin.
We currently don't have a good way of generating core files (at least for elf, it requires some additional features in yaml2obj). We have a couple of tiny (dozens of KB) elf core files checked in, and you may be even able to reuse one of them. For an example of a fake OS plugin, you can look at TestPythonOSPlugin.

I don't guarantee this will actually work (did I say I don't know OS plugins ? :D), but it's the only solution I can think of.


Repository:
  rL LLVM

https://reviews.llvm.org/D44139