[Lldb-commits] [PATCH] D43912: [Symbol] Add InvalidType, a force-checked recoverable error

Jim Ingham via lldb-commits lldb-commits at lists.llvm.org
Thu Mar 1 10:25:39 PST 2018


I have no general objections to macros, and reducing boiler-plate is good.  They do get in the way of debugging because of the weird C rule that a macro has to pretend that it is all one source line, so if they contain code you are interested in stopping at, there needs to be some other way to do that.  But provided that's taken care of, they are fine.

Jim


> On Mar 1, 2018, at 10:16 AM, Zachary Turner via Phabricator <reviews at reviews.llvm.org> wrote:
> 
> zturner added a comment.
> 
> I'm also ok with not having the macro fwiw, just an idea to reduce boilerplate.
> 
> 
> https://reviews.llvm.org/D43912
> 
> 
> 



More information about the lldb-commits mailing list