[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

[Vedant Kumar via Phabricator via lldb-commits]

vsk added a comment.

I'm concerned about the time it takes to run the test suite. If we can get decent test coverage of this patch without adding a new debug info flavor, that'd be ideal.



================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:718
                             self.getBuildDirBasename())
-    
-     
+
+
----------------
clayborg wrote:
> davide wrote:
> > spurious whitespaces, please revert.
> It is removing spurious whitespaces and there are other changes in this file. Most editors these days will remove spurious spaces and we should strive to remove them where possibly no?
No, we generally avoid making changes that are unrelated to the patch, as they make patch review and subsequent merges harder.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDataExtractor.h:58
+      m_start -= offset;
+  }
+  
----------------
Please clang-format your diffs.


https://reviews.llvm.org/D32167