[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

[Greg Clayton via Phabricator via lldb-commits]

clayborg added a comment.

In https://reviews.llvm.org/D32167#1019504, @clayborg wrote:

> In https://reviews.llvm.org/D32167#1019467, @labath wrote:
>
> > So, I tried this out on my machine, and got just one failure:
> >
> >   ======================================================================
> >   FAIL: test_with_run_command_dwarf_type_units (TestInlinedBreakpoints.InlinedBreakpointsTestCase)
> >      Test 'b basic_types.cpp:176' does break (where int.cpp includes basic_type.cpp).
> >   ----------------------------------------------------------------------
> >   Traceback (most recent call last):
> >     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/lldbtest.py", line 1827, in dwarf_type_units_test_method
> >       return attrvalue(self)
> >     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/inlined_breakpoints/TestInlinedBreakpoints.py", line 24, in test_with_run_command
> >       self.inlined_breakpoints()
> >     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/functionalities/breakpoint/inlined_breakpoints/TestInlinedBreakpoints.py", line 46, in inlined_breakpoints
> >       self, "basic_type.cpp", self.line, num_expected_locations=0)
> >     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 376, in run_break_set_by_file_and_line
> >       num_locations=num_expected_locations)
> >     File "/usr/local/google/home/labath/ll/lldb/packages/Python/lldbsuite/test/lldbutil.py", line 572, in check_breakpoint_result
> >       out_num_locations))
> >   AssertionError: False is not True : Expecting 0 locations, got 1.
> >
>
>
> I saw this too. When I ran _any_ of the variants manually, they all failed to set any breakpoints. Not sure this test is testing what it claims to be testing.


Actually I can repro this and will look into it


https://reviews.llvm.org/D32167