[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

[Davide Italiano via Phabricator via lldb-commits]

davide requested changes to this revision.
davide added a comment.
This revision now requires changes to proceed.

This commit has no tests. It should have many. It's very big, so it could be split in several pieces.
I'd really appreciate if you can take the time to do so. For now, some comments.



================
Comment at: include/lldb/lldb-enumerations.h:659
                                // address
+  eSectionTypeDWARFDebugTypes,
   eSectionTypeOther
----------------
this needs a comment.


================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:718
                             self.getBuildDirBasename())
-    
-     
+
+
----------------
spurious whitespaces, please revert.


================
Comment at: packages/Python/lldbsuite/test/lldbtest.py:1782
                         x, target_platform, configuration.compiler)]
-                
+
                 if "dsym" in supported_categories:
----------------
ditto.


================
Comment at: source/Plugins/SymbolFile/DWARF/DIERef.cpp:50
     if (dwarf_cu) {
-      if (dwarf_cu->GetBaseObjOffset() != DW_INVALID_OFFSET)
-        cu_offset = dwarf_cu->GetBaseObjOffset();
-      else
-        cu_offset = dwarf_cu->GetOffset();
+      // Replace the compile unit with the type signature compile unit for
+      // type signature attributes.
----------------
Why? This needs to be explained in a comment.


================
Comment at: source/Plugins/SymbolFile/DWARF/DWARFDebugInfo.h:64
   typedef std::vector<DWARFCompileUnitSP> CompileUnitColl;
-
+  typedef std::unordered_map<uint64_t, uint32_t> TypeSignatureMap;
   //----------------------------------------------------------------------
----------------
any reason why you can't use LLVM adt?


https://reviews.llvm.org/D32167