[Lldb-commits] [PATCH] D43698: Plug errno in TCPSocket::Connect()

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 15:23:12 PST 2018


labath added a comment.

Yes, but that's why we have the Error objects, so we don't have to do the errno save-restore dance.

If this is just a debugging aid, then maybe you should keep it as such (locally). There are plenty of places that will leave a stray errno around and I don't think we want to do this resetting on all of them.


Repository:
  rL LLVM

https://reviews.llvm.org/D43698





More information about the lldb-commits mailing list