[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 23 11:58:55 PST 2018


clayborg added a comment.

If any of our lldb_private::Process subclasses handle this already, then we need a new virtual function on lldb_private::Process like:

  virtual bool lldb_private::Process::MemoryWorksAroundSoftwareBreakpoints(bool read);

If "read" is true then we are asking about memory reads and if "read" is false, then we are asking about writes. Then the code you added to disable breakpoint locations and re-enable them only needs to happen if they return false to calling this function with "read == false".


https://reviews.llvm.org/D39967





More information about the lldb-commits mailing list