[Lldb-commits] [PATCH] D39967: Disable breakpoints before writing memory and re-enable after.

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 22 16:31:08 PST 2018

labath added inline comments.

Comment at: include/lldb/Breakpoint/BreakpointSiteList.h:159-161
+  class Guard : private std::unique_lock<std::recursive_mutex> {
+    using std::unique_lock<std::recursive_mutex>::unique_lock;
+  };
zturner wrote:
> Err, I meant to just deleted the `Guard` class entirely and return `llvm::Optional<std::unique_lock<std::recursive_mutex>>`
You don't even need the Optional class, unique_lock already has an uninitialized state.


More information about the lldb-commits mailing list