[Lldb-commits] [PATCH] D43647: Generate most of the target properties from a central specification.

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 22 16:08:23 PST 2018


jingham added a comment.

What would I have to figure out if I wanted to stop where one of these properties was actually set or read?  That's something I've had to do many's the time...  This task is straightforward in the original, and if it's not too bad to cons up the name from this macro goo then I'm over all in favor.  I'm not a big fan of macros, but what this is replacing wasn't all that pretty either.

Also (though you probably knew this) there are Properties in a lot of classes, so to do it properly you would have to have be able to move all the goo but including the individual defs files to the Properties.h for this to be viable.


Repository:
  rL LLVM

https://reviews.llvm.org/D43647





More information about the lldb-commits mailing list