[Lldb-commits] [PATCH] D42145: [lldb] Use vFlash commands when writing to target's flash memory regions

Greg Clayton via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 22 08:53:24 PST 2018

clayborg added inline comments.

Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:3478
+    auto header = GetProgramHeaderByIndex(i);
+    if (header->p_paddr != 0)
+      return true;
Can't p_paddr be zero and still be valid? Would a better test be "header->p_memsz > 0"?


More information about the lldb-commits mailing list