[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

Adrian Prantl via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Thu Feb 22 08:23:21 PST 2018

aprantl added a comment.

In https://reviews.llvm.org/D43596#1015903, @clayborg wrote:

> The only input we currently use this on is DWARF and I believe all DWARF strings are UTF8 so this should all work correctly, no?

The hashing algorithms produced different hashes for characters with bit 7 set. That would apply for all UTF-8 characters that are outside of the 7-bit ascii range.

Jonas, do we have any tests in LLDB that try to lookup a variable with non-ASCII characters?


More information about the lldb-commits mailing list