[Lldb-commits] [PATCH] D43596: Replace HashStringUsingDJB with llvm::djbHash

[Adrian Prantl via Phabricator via lldb-commits]

aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.


================
Comment at: include/lldb/Core/MappedHash.h:156
-  template <typename __KeyType, class __HeaderDataType, class __ValueType>
-  class ExportTable {
-  public:
----------------
Yeah this looks like it was a dead end dating back to 2011.


================
Comment at: source/Target/ObjCLanguageRuntime.cpp:49
     // class_name is assumed to be valid
-    m_hash_to_isa_map.insert(
-        std::make_pair(MappedHash::HashStringUsingDJB(class_name), isa));
+    m_hash_to_isa_map.insert(std::make_pair(llvm::djbHash(class_name), isa));
     return true;
----------------
`m_hash_to_isa_map.insert({llvm::djbHash(class_name), isa});`


https://reviews.llvm.org/D43596