[Lldb-commits] [PATCH] D43419: Fix TestBreakpointInGlobalConstructor for Windows

Adrian McCarthy via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 20 12:45:02 PST 2018

amccarth added a comment.

In https://reviews.llvm.org/D43419#1013559, @jingham wrote:

> At some point we should introduce "platformCapacities" so that you could do:
>   if not test.getPlatformCapacities("preload-dylibs"):
> so we are testing specific features not the whole platform.

Yes, I agree completely.

> It looks like your added comment has no line endings?  Can you reformat the comment so it's easier to read?  Then it will be good.

Done.  I'm never sure how Python handles docstrings.  The existing code looked like it was trying to avoid line breaks that weren't separating paragraphs.


More information about the lldb-commits mailing list