[Lldb-commits] [PATCH] D43419: Fix TestBreakpointInGlobalConstructor for Windows

Jim Ingham via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 20 12:22:26 PST 2018

jingham requested changes to this revision.
jingham added a comment.
This revision now requires changes to proceed.

At some point we should introduce "platformCapacities" so that you could do:

  if not test.getPlatformCapacities("preload-dylibs"):

so we are testing specific features not the whole platform.  But that seems a bigger change than this fix warrants.

It looks like your added comment has no line endings?  Can you reformat the comment so it's easier to read?  Then it will be good.


More information about the lldb-commits mailing list