[Lldb-commits] [PATCH] D43506: Fix a couple of more tests to not create files in the source tree

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Tue Feb 20 03:26:15 PST 2018


labath created this revision.
labath added reviewers: davide, aprantl.

These were not being flaky, but they're still making the tree dirty.

These tests were using lldbutil.append_to_process_working_directory to
derive the file path so I fix them by modifying the function to return
the build directory for local tests.

Technically, now the path returned by this function does not point to
the process working directory for local tests, but I think it makes
sense to keep the function name, as I think we should move towards
launching the process in the build directory (and I intend to change
this for the handful of inferiors that actually care about their PWD,
for example because they need to create files there).


https://reviews.llvm.org/D43506

Files:
  packages/Python/lldbsuite/test/functionalities/process_attach/attach_denied/TestAttachDenied.py
  packages/Python/lldbsuite/test/functionalities/process_group/TestChangeProcessGroup.py
  packages/Python/lldbsuite/test/lldbtest.py
  packages/Python/lldbsuite/test/lldbutil.py
  packages/Python/lldbsuite/test/python_api/target/TestTargetAPI.py
  packages/Python/lldbsuite/test/tools/lldb-server/TestGdbRemoteModuleInfo.py
  packages/Python/lldbsuite/test/tools/lldb-server/gdbremote_testcase.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43506.135040.patch
Type: text/x-patch
Size: 8585 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180220/6aa5c47d/attachment.bin>


More information about the lldb-commits mailing list