[Lldb-commits] [lldb] r325495 - Make gdb-client tests generate binaries in the build tree

Pavel Labath via lldb-commits lldb-commits at lists.llvm.org
Mon Feb 19 05:53:12 PST 2018

Author: labath
Date: Mon Feb 19 05:53:12 2018
New Revision: 325495

URL: http://llvm.org/viewvc/llvm-project?rev=325495&view=rev
Make gdb-client tests generate binaries in the build tree

These were missed in the great refactor because they were added
concurrently with it. Since we started running tests in a more parallel
fashion they started to be flaky. This should fix it.

Now that we are no longer polluting the source tree, I also delete the
bit of custom cleanup code specific to these tests.


Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py?rev=325495&r1=325494&r2=325495&view=diff
--- lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py (original)
+++ lldb/trunk/packages/Python/lldbsuite/test/functionalities/gdb_remote_client/gdbclientutils.py Mon Feb 19 05:53:12 2018
@@ -392,24 +392,19 @@ class GDBRemoteTestBase(TestBase):
     mydir = TestBase.compute_mydir(__file__)
     server = None
-    temp_files = None
     def setUp(self):
-        self.temp_files = []
         self.server = MockGDBServer()
     def tearDown(self):
-        for temp_file in self.temp_files:
-            self.RemoveTempFile(temp_file)
         # TestBase.tearDown will kill the process, but we need to kill it early
         # so its client connection closes and we can stop the server before
         # finally calling the base tearDown.
         if self.process() is not None:
-        self.temp_files = []
     def createTarget(self, yaml_path):
@@ -421,9 +416,8 @@ class GDBRemoteTestBase(TestBase):
         during tearDown.
         yaml_base, ext = os.path.splitext(yaml_path)
-        obj_path = "%s" % yaml_base
+        obj_path = self.getBuildArtifact(yaml_base)
         self.yaml2obj(yaml_path, obj_path)
-        self.temp_files.append(obj_path)
         return self.dbg.CreateTarget(obj_path)
     def connect(self, target):

More information about the lldb-commits mailing list