[Lldb-commits] [PATCH] D43376: Fix TestStopReplyContainsThreadPcs on 32-bit x86 (pr36013)

Pavel Labath via Phabricator via lldb-commits lldb-commits at lists.llvm.org
Fri Feb 16 02:07:23 PST 2018


labath created this revision.
labath added reviewers: eugene, davide.

The issue was that we were parsing the registers into 64-bit integers
and the calling swapByteOrder without regard for the actual size of the
register. This switches the test to use the RegisterValue class which
tracks the register size, and knows how to initialize itself from a
piece of memory (so we don't need to swap byte order ourselves).


https://reviews.llvm.org/D43376

Files:
  unittests/tools/lldb-server/tests/MessageObjects.cpp
  unittests/tools/lldb-server/tests/MessageObjects.h
  unittests/tools/lldb-server/tests/TestClient.cpp
  unittests/tools/lldb-server/tests/TestClient.h
  unittests/tools/lldb-server/tests/ThreadIdsInJstopinfoTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43376.134575.patch
Type: text/x-patch
Size: 18716 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20180216/c3430144/attachment-0001.bin>


More information about the lldb-commits mailing list