[Lldb-commits] [lldb] r325188 - Supply missing break in case statement.

Adrian McCarthy via lldb-commits lldb-commits at lists.llvm.org
Wed Feb 14 15:16:37 PST 2018


Author: amccarth
Date: Wed Feb 14 15:16:36 2018
New Revision: 325188

URL: http://llvm.org/viewvc/llvm-project?rev=325188&view=rev
Log:
Supply missing break in case statement.

Summary:
All the tests pass without hitting the situation mentioned in the FIXME, so,
per Aaron Smith's suggestion, this case will now return unconditionally.

Subscribers: sanjoy, mgorny, JDevlieghere

Differential Revision: https://reviews.llvm.org/D43215

Modified:
    lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp

Modified: lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp?rev=325188&r1=325187&r2=325188&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp (original)
+++ lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp Wed Feb 14 15:16:36 2018
@@ -107,9 +107,7 @@ CompilerType GetBuiltinTypeForPDBEncodin
   case PDB_BuiltinType::None:
     return CompilerType();
   case PDB_BuiltinType::Void:
-    // FIXME: where is non-zero size of `void` from?
-    if (width == 0)
-      return clang_ast->GetBasicType(eBasicTypeVoid);
+    return clang_ast->GetBasicType(eBasicTypeVoid);
   case PDB_BuiltinType::Bool:
     return clang_ast->GetBasicType(eBasicTypeBool);
   case PDB_BuiltinType::Long:




More information about the lldb-commits mailing list