[Lldb-commits] [PATCH] D42994: Stop passing -fPIC to lldb tests on Windows
Pavel Labath via Phabricator via lldb-commits
lldb-commits at lists.llvm.org
Wed Feb 7 03:13:59 PST 2018
labath added a comment.
In https://reviews.llvm.org/D42994#999891, @zturner wrote:
> In the future when you upload diffs can you include context? (i.e. `git diff -U999999`). It's nice to be able to see the surrounding code when I'm looking at a diff.
> Is there ever a case where you would want to build a shared library without `-fPIC`? I'm wondering if we should just update the common `Makefile.rules` and if `DYLIB_NAME` is set (or something else indicating that this is a shared library), then we put the logic about `-fPIC` in that common file. Then people wouldn't have to remember to get this right in the future.
Adding -fPIC by default sounds like a great idea. Building a shared library without it will probably break compilation, but if some test still wants to try it, it can be turned off with `-fno-PIC`.
More information about the lldb-commits